From 8cf872a4b03e7a4d0de4661afd04c2fb8f15ce65 Mon Sep 17 00:00:00 2001 From: relikd Date: Wed, 17 Jun 2020 01:49:46 +0200 Subject: [PATCH] Todos --- main/Data Source/GroupedDomainDataSource.swift | 8 +++++--- main/Requests/TVCHostDetails.swift | 1 + 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/main/Data Source/GroupedDomainDataSource.swift b/main/Data Source/GroupedDomainDataSource.swift index de93310..e9276c1 100644 --- a/main/Data Source/GroupedDomainDataSource.swift +++ b/main/Data Source/GroupedDomainDataSource.swift @@ -45,8 +45,9 @@ class GroupedDomainDataSource: FilterPipelineDelegate, SyncUpdateDelegate { /// Read user defaults and apply new sorting order. Either by setting a new or reversing the current. /// - Parameter force: If `true` set new sorting even if the type does not differ. private func resetSortingOrder(force: Bool = false) { - let orderDidChange = (orderAsc <-? Pref.DateFilter.OrderAsc) - if currentOrder <-? Pref.DateFilter.OrderBy || force { + let orderAscChanged = (orderAsc <-? Pref.DateFilter.OrderAsc) + let orderTypChanged = (currentOrder <-? Pref.DateFilter.OrderBy) + if orderTypChanged || force { switch currentOrder { case .Date: pipeline.setSorting { [unowned self] in @@ -61,7 +62,7 @@ class GroupedDomainDataSource: FilterPipelineDelegate, SyncUpdateDelegate { self.orderAsc ? $0.total < $1.total : $0.total > $1.total } } - } else if orderDidChange { + } else if orderAscChanged { pipeline.reverseSorting() } } @@ -223,6 +224,7 @@ extension GroupedDomainDataSource { // ################################ extension GroupedDomainDataSource { + // TODO: permanently show search bar as table header? func toggleSearch() { if search.active { search.hide() } else { diff --git a/main/Requests/TVCHostDetails.swift b/main/Requests/TVCHostDetails.swift index 47639ba..544de4b 100644 --- a/main/Requests/TVCHostDetails.swift +++ b/main/Requests/TVCHostDetails.swift @@ -4,6 +4,7 @@ class TVCHostDetails: UITableViewController, SyncUpdateDelegate { public var fullDomain: String! private var dataSource: [GroupedTsOccurrence] = [] + // TODO: respect date reverse sort order override func viewDidLoad() { navigationItem.prompt = fullDomain