Updated TODOs

This commit is contained in:
relikd
2019-01-15 02:21:04 +01:00
parent 3d6865657b
commit 55850832d8
6 changed files with 5 additions and 38 deletions

View File

@@ -40,7 +40,6 @@
}
- (void)applicationDidFinishLaunching:(NSNotification *)aNotification {
printf("up and running\n");
// feed://https://feeds.feedburner.com/simpledesktops
[FeedDownload registerNetworkChangeNotification]; // will call update scheduler
}

View File

@@ -26,6 +26,8 @@
// TODO: Add support for media player? image feed?
// <enclosure url="https://url.mp3" length="63274022" type="audio/mpeg" />
// TODO: Disable 'update all' menu item during update?
// TODO: List of hidden preferences for readme
// TODO: Do we need to search for favicon in places other than '../favicon.ico'?
static NSString *kNotificationFeedUpdated = @"baRSS-notification-feed-updated";
static NSString *kNotificationNetworkStatusChanged = @"baRSS-notification-network-status-changed";

View File

@@ -254,7 +254,6 @@ static BOOL _nextUpdateIsForced = NO;
} else {
[feed.meta setSucessfulWithResponse:response];
if (rss) [feed updateWithRSS:rss postUnreadCountChange:YES];
// TODO: save changes for this feed only? / Partial Update
[successful addObject:feed]; // will be added even if statusCode == 304 (rss == nil)
}
dispatch_group_leave(group);

View File

@@ -157,6 +157,7 @@
if (self.modalSheet.didCloseAndCancel)
return;
[self preDownload];
// TODO: parse webpage to find feed links instead (automatic link detection)
[FeedDownload newFeed:self.previousURL block:^(RSParsedFeed *result, NSError *error, NSHTTPURLResponse* response) {
if (self.modalSheet.didCloseAndCancel)
return;
@@ -178,7 +179,6 @@
if (self.modalSheet.didCloseAndCancel)
return;
// 1. Stop spinner animation for name field. (keep spinner for URL running until favicon downloaded)
// TODO: play error sound?
[self.spinnerName stopAnimation:nil];
// 2. If URL was redirected, replace original text field value with new one. (e.g., https redirect)
if (responseURL.length > 0 && ![responseURL isEqualToString:self.previousURL]) {
@@ -194,7 +194,7 @@
if (self.feedError) {
[self finishDownloadWithFavicon:[NSImage imageNamed:NSImageNameCaution]];
} else {
NSString *faviconURL = self.feedResult.link; // TODO: add support for custom URLs ?
NSString *faviconURL = self.feedResult.link;
if (faviconURL.length == 0)
faviconURL = responseURL;
[FeedDownload downloadFavicon:faviconURL finished:^(NSImage * _Nullable img) {

View File

@@ -362,7 +362,7 @@ static NSString *dragNodeType = @"baRSS-feed-drag";
}
[[NSPasteboard generalPasteboard] clearContents];
[[NSPasteboard generalPasteboard] setString:str forType:NSPasteboardTypeString];
NSLog(@"%@", str);
NSLog(@"%@", str); // TODO: drag-n-drop feed to opml?
}
/**